Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document, cleanup and fix some theme properties #82409

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Document, cleanup and fix some theme properties #82409

merged 1 commit into from
Oct 17, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Sep 26, 2023 •
edited
Loading

Somewhat follow-up to #81573

I wanted to add descriptions to the 3 newly "exposed" theme items, but found some obstacles along the way.

  • Adds description for Button's icon
  • Removes hscroll theme property from ScrollBar and the related get_area_offset() method (it was unused)
  • Documents and fixes GraphEdit's activity theme property

@KoBeWi KoBeWi added this to the 4.2 milestone Sep 26, 2023
@KoBeWi KoBeWi requested review from a team as code owners September 26, 2023 21:55
@YuriSizov
Copy link
Contributor

I think you'll have to run the doctool for ScrollBar 👀

@akien-mga akien-mga merged commit 024172b into godotengine:master Oct 17, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the 3_in_1 branch October 17, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
bug documentation enhancement topic:gui
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@KoBeWi @YuriSizov @akien-mga