Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clamp ReflectionProbe Max Distance to 262,144 to fix rendering issues #82415

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Clamp ReflectionProbe Max Distance to 262,144 to fix rendering issues #82415

merged 1 commit into from
Oct 26, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Sep 27, 2023 •
edited
Loading

I have an alternative solution that automatically sets near clip above 0.01 if needed, but it may be less robust (and I doubt there are many use cases for reflection probes that large anyway).

@Calinou Calinou requested a review from a team as a code owner September 27, 2023 00:20
@Calinou Calinou added this to the 4.2 milestone Sep 27, 2023
clayjohn
clayjohn approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If users need larger distances than we can think about adjusting the near value. But for now I doubt anyone will actually bump up against this limit.

@Calinou Calinou added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 25, 2023
@akien-mga akien-mga merged commit 79e9e20 into godotengine:master Oct 26, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the reflectionprobe-fix-high-max-distance-rendering-2 branch October 26, 2023 17:30
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@Calinou Calinou mentioned this pull request Feb 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:rendering topic:3d
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Vulkan: Reflection probe rendering breaks if Max Distance is greater than 262144
4 participants
@Calinou @akien-mga @YuriSizov @clayjohn