Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Fix build with Xcode 15. #82458

Merged
merged 1 commit into from
Sep 30, 2023
Merged

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 27, 2023

Bugsquad edit:

@bruvzg bruvzg added this to the 3.x milestone Sep 27, 2023
@bruvzg bruvzg requested review from a team as code owners September 27, 2023 18:30
@bruvzg bruvzg modified the milestones: 3.x, 4.2 Sep 27, 2023
Copy link

@Scoppio Scoppio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are changing the xcode build target, there is need to add the target change to the documentation as well, those two cannot be different, otherwise we endup with a doc that says you can build for iPhone 11 and an engine that only targets 12 and up.

@akien-mga
Copy link
Member

We should fix the build issue on 4.1/4.0 and 3.x/3.5, but ideally there I would like to preserve iOS 11 support (at least for release branches, for 3.x we could bump to 12).

@LeandroHPerez
Copy link

@akien-mga
@bruvzg

I noticed that it is not possible to downgrade xcode to version 14.x.
The newest version (Xcode 14.3.1) is not compatible with Macos Sonoma 14.0.
Therefore, if the bug is not fixed, users with Macos Sonoma will not be able to export the Godot project to iOS.
Only Xcode version 15 runs on macos sonoma.

@bruvzg
Copy link
Member Author

bruvzg commented Sep 29, 2023

but ideally there I would like to preserve iOS 11 support

I'll take a look if it's possible, but I do not think there's any reason to support it. Unlike iOS 12, iOS 11 is completely obsolete and does not receive security updates for 5 years, no one should use it.

@akien-mga
Copy link
Member

Ok, let's drop iOS 11 then, if Apple forces our hand there's no reason to fight them.

@akien-mga akien-mga added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Sep 30, 2023
@akien-mga akien-mga merged commit c952751 into godotengine:master Sep 30, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.1.2.

@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 3, 2023
@LeandroHPerez
Copy link

LeandroHPerez commented Oct 4, 2023

I came here to inform that i tested on brand new 4.2-dev6 and cannot perfectly build it in xcode 15 with macbook with Apple Silicon yet....

But now, minimum iOS version is 12.0, this is OK.

Errors:
image

Complete project and configuration can be found here:
#82551
but now de Godot version is 4.2-dev6

@bruvzg
@akien-mga

@stevencodeuk
Copy link

With this issue still existing, what is currently the best combo versions of Godot 4/Xcode to export iOS with plugins with?

@akien-mga akien-mga removed cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Jan 18, 2024
@AsielPosada
Copy link

Facing same issue currently with v4.2.2.stable.official [15073af]
image

@akien-mga
Copy link
Member

Which Xcode version do you have? The upstream bug was fixed in 15.2.

@bruvzg
Copy link
Member Author

bruvzg commented Jun 2, 2024

Facing same issue currently with v4.2.2.stable.official

Are you trying to run it in the simulator on Apple Silicon Mac? Official templates include only x86_64 simulator and arm64 device libs, but not arm64 simulator lib (it's build with OSXCross, and it still not capable of building it). You can run it on the real iOS device, or select "This mac" instead of simulator, or run Xcode under Rosetta to use x86_64, or build a custom template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exported XCode project won't build
6 participants