Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add XInput device ID for wireless Series 2 Elite controller #82508

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Add XInput device ID for wireless Series 2 Elite controller #82508

merged 1 commit into from
Oct 9, 2023

Conversation

floatingpointer
Copy link
Contributor

@floatingpointer floatingpointer commented Sep 29, 2023 •
edited
Loading

Adds to the list of XInput GUIDs the XInput device ID for the Xbox One Elite Series 2 controller when connected wirelessly.

Resolves #81816

Change is compatible with 3.x.

@floatingpointer
Update joypad_windows.cpp
81f9c03 
Add XInput device for Series 2 Elite controller
@floatingpointer floatingpointer requested a review from a team as a code owner September 29, 2023 02:00
@floatingpointer floatingpointer mentioned this pull request Sep 29, 2023
Closed
@Sauermann Sauermann added this to the 4.2 milestone Sep 29, 2023
Sauermann
Sauermann approved these changes Oct 8, 2023
View reviewed changes
Copy link
Contributor

@Sauermann Sauermann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the bug in v4.2.dev.custom_build [6916349] on Windows 10 when connected via Bluetooth.

I have tested the PR (rebased on v4.2.dev.custom_build [6916349]) and can confirm, that it solves the bug in the provided MRP.

Can't say anything about the implementation.

Calinou
Calinou approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test this either due to not owning an Xbox Elite 2 controller, but this implementation makes sense to me.

@Calinou Calinou added cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 8, 2023
@akien-mga akien-mga merged commit 5a3befd into godotengine:master Oct 9, 2023
15 checks passed
@akien-mga
Copy link
Member

akien-mga commented Oct 9, 2023 •
edited
Loading

Thanks! And congrats for your first merged Godot contribution 🎉

Note for future contributions: Please make sure to use clear commit messages that describe what the problem is (like the title of this PR), instead of generic "Update <name of file>" like done here (probably suggested by your IDE, sadly...).

@floatingpointer
Copy link
Contributor Author

Got it, thank you!

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@akien-mga
Copy link
Member

Cherry-picked for 3.6.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 16, 2024
@akien-mga
Copy link
Member

Cherry-picked for 3.5.4.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sauermann Sauermann Sauermann approved these changes

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:input topic:porting
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Right stick up-down input not working properly with Xbox Elite Wireless Controller Series 2
5 participants
@floatingpointer @akien-mga @YuriSizov @Calinou @Sauermann