Make the lightmapper not dilate before denoising. #82533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dilating noisy data caused issues for the denoiser. Fixes godotengine#82526.
|
I can confirm that this fixes the issue Before After Sorry I moved the camera between screenshots |
akien-mga
approved these changes
Sep 29, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dilating noisy data caused issues for the denoiser. Fixes #82526.
Upon merging the new denoiser, which filters out invalid pixels from being part of the algorithm, there was a problem where noisy pixels would be dilated first and the denoiser wouldn't be able to fix it.
In retrospect, the fix is fairly obvious and it makes sense: denoise valid data first, and then do the dilation with the valid data only, not the noisy pixels.
This fixes the noise present in seams that made its way in once the half pixel offset started being used in the denoiser branch.
Before
After