Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript: Fix UNSAFE_CALL_ARGUMENT warning for Variant constructors #82547

Merged
merged 1 commit into from
Oct 3, 2023
Merged

GDScript: Fix UNSAFE_CALL_ARGUMENT warning for Variant constructors #82547

merged 1 commit into from
Oct 3, 2023

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev added this to the 4.2 milestone Sep 29, 2023
@dalexeev dalexeev requested a review from a team as a code owner September 29, 2023 19:47
@dalexeev dalexeev force-pushed the gds-fix-unsafe-call-arg-variant-constructors branch from e948ce4 to ba96d4f Compare September 30, 2023 11:02
adamscott
adamscott approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved during the GDScript team meeting. Thanks!

@akien-mga akien-mga merged commit e41582f into godotengine:master Oct 3, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the gds-fix-unsafe-call-arg-variant-constructors branch October 3, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

Assignees
No one assigned
Labels
bug enhancement topic:gdscript
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

"unsafe call argument" GDScript warning shows up with safe argument
3 participants
@dalexeev @akien-mga @adamscott