GDScript: Improve error messages for invalid indexing #82639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golfinq
force-pushed
the
gdscript-improve-indexing-error
branch
from
ed922d5 to
e9a7613
Compare
golfinq
force-pushed
the
gdscript-improve-indexing-error
branch
from
e9a7613 to
c6becd5
Compare
|
Should I edit the failing tests to accommodate the new error messages? |
Yep |
These errors are very common when using an invalid property name or calling on an object of the wrong type, and the previous message was a bit cryptic for users. Co-authored-by: Rémi Verschelde <rverschelde@gmail.com> Co-authored-by: golfinq <golfinqz@gmail.com>
golfinq
force-pushed
the
gdscript-improve-indexing-error
branch
from
c6becd5 to
5efbed5
Compare
adamscott
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Pre-approved during the GDScript team meeting. Members of the team have been asked to check the PR and the errors formulation in order to make sure that they are correct, but for the most part, this seems like a great improvement.
This raises the question about Godot supporting global error codes, both in GDScript and in the Godot core itself.
Calinou
approved these changes
Oct 4, 2023
AThousandShips
approved these changes
Jan 4, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take over of #66948
Changes from the pull request are the addition of enums which specifies why the variant getter/setter failed, and changes the message to a more useful one on failure of getting/setting an index