Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NavigationAgent3D.target_position documentation readability #82671

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

Flynsarmy
Copy link
Contributor

I know this is a tiny commit but I had to read this sentence 4 times before I figured out what it was trying to say. The comma is important here.

Examples of where the same type of documentation has the comma are here, here, here amongst many other instances.

@smix8
Copy link
Contributor

smix8 commented Oct 2, 2023

For parity this should be mirrored on the NavigationAgent2D.

@Flynsarmy
Copy link
Contributor Author

Added!

@akien-mga
Copy link
Member

Looks good! Could you squash the commits? See PR workflow for instructions.

@akien-mga akien-mga added this to the 4.2 milestone Oct 2, 2023
Improve NavigationAgent2D.target_position documentation readability
@akien-mga akien-mga changed the title Improve NavigationAgent3D.target_position documentation readability Improve NavigationAgent3D.target_position documentation readability Oct 2, 2023
@akien-mga akien-mga merged commit 5e19247 into godotengine:master Oct 2, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@Flynsarmy Flynsarmy deleted the the_humble_comma branch October 2, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants