GDExtension: Don't deprecate old method of getting script category #82682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to PR #78995
That PR allows GDExtensions to take control over the class category used for script instances (when you're adding a scripting language from a GDExtension). However, in many (most?) cases, GDExtensions don't need this extra control and the old, default method is just fine.
So, rather than deprecating the old behavior, I think this should just be a case where there's two ways to handle this: (1) provide a
get_class_category_func
if you want the extra control, or (2) providenullptr
if the default behavior is fine.This PR just removes the
#ifndef DISABLE_DEPRECATED
that wraps the old behavior, and adds a comment to thegdextension_interface.h
.