Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forgot to add debanding to config object #82766

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Forgot to add debanding to config object #82766

merged 1 commit into from
Oct 4, 2023

Conversation

BastiaanOlij
Copy link
Contributor

When changing the rendering code from sending lots of parameters to our render buffers configuration object, to a configuration object so it's more extendable future proof, we forgot to set the debanding flag.

This may fix #80751

@BastiaanOlij BastiaanOlij added this to the 4.2 milestone Oct 4, 2023
@BastiaanOlij BastiaanOlij requested a review from a team as a code owner October 4, 2023 05:25
@BastiaanOlij BastiaanOlij self-assigned this Oct 4, 2023
@BastiaanOlij BastiaanOlij mentioned this pull request Oct 4, 2023
Closed
@mrjustaguy
Copy link
Contributor

Resolved the issue.

@akien-mga akien-mga merged commit ccbb911 into godotengine:master Oct 4, 2023
@akien-mga
Copy link
Member

Thanks!

@BastiaanOlij BastiaanOlij deleted the fix_debanding_issue branch October 5, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees

@BastiaanOlij BastiaanOlij

Labels
bug topic:rendering topic:3d
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Debanding stops applying when the project restarts or TAA is toggled
4 participants
@BastiaanOlij @mrjustaguy @akien-mga @clayjohn