Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve relative icon paths for GDExtensions #82842

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Resolve relative icon paths for GDExtensions #82842

merged 1 commit into from
Oct 5, 2023

Conversation

YuriSizov
Copy link
Contributor

@YuriSizov YuriSizov commented Oct 5, 2023 •
edited
Loading

See #82810. This is the same thing we do for libraries, so it should just work, I think.

cc @mihe for testing :)

@YuriSizov YuriSizov added this to the 4.2 milestone Oct 5, 2023
@YuriSizov YuriSizov requested a review from a team as a code owner October 5, 2023 10:50
@YuriSizov YuriSizov mentioned this pull request Oct 5, 2023
Closed
akien-mga
akien-mga approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully with https://github.com/akien-mga/threen.

dsnopek
dsnopek approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested, but the code looks good to me! (And this is definitely a feature I've wanted for my own GDExtensions :-))

mihe
mihe approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@mihe mihe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just gave this a try and it seems to work, as best I can tell. Thank you!

@akien-mga akien-mga merged commit af232e6 into godotengine:master Oct 5, 2023
15 checks passed
@YuriSizov YuriSizov deleted the gdext-icons-are-relative-maaaan branch October 5, 2023 15:45
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihe mihe mihe approved these changes

@akien-mga akien-mga akien-mga approved these changes

@dsnopek dsnopek dsnopek approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:gdextension
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@YuriSizov @akien-mga @dsnopek @mihe