Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt require editor restart to user when gizmo color changed #82872

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Prompt require editor restart to user when gizmo color changed #82872

merged 1 commit into from
Dec 19, 2023

Conversation

jsjtxietian
Copy link
Contributor

Fixes #82813

@jsjtxietian jsjtxietian requested a review from a team as a code owner October 5, 2023 17:30
@Calinou
Copy link
Member

Calinou commented Oct 5, 2023 •
edited
Loading

EDITOR_DEF should be changed to EDITOR_DEF_RST for all 3D editor gizmos, not just CSG. (I believe these all require a restart to make the changes visible.)

@Calinou Calinou added bug topic:editor topic:3d cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 5, 2023
@Calinou Calinou added this to the 4.2 milestone Oct 5, 2023
@jsjtxietian jsjtxietian force-pushed the require-editor-restart-when-csg-gizmo-color-changed branch from ee5a826 to a4fe5a9 Compare October 6, 2023 05:54
@jsjtxietian jsjtxietian requested a review from a team as a code owner October 6, 2023 05:54
@jsjtxietian jsjtxietian changed the title Prompt require editor restart to user when gizmo color csg changed Prompt require editor restart to user when gizmo color changed Oct 6, 2023
@jsjtxietian jsjtxietian force-pushed the require-editor-restart-when-csg-gizmo-color-changed branch from a4fe5a9 to b0ccd5c Compare October 6, 2023 07:02
@jsjtxietian jsjtxietian requested a review from fire October 13, 2023 09:56
@akien-mga akien-mga modified the milestones: 4.2, 4.3 Nov 9, 2023
@akien-mga akien-mga added cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release and removed cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Nov 9, 2023
@YuriSizov
Copy link
Contributor

Why does this need an editor restart in the first place? This should be something we can update on the fly, surely?

@akien-mga
Copy link
Member

It could be updated on the fly yes, that's just more work :P

@YuriSizov YuriSizov merged commit e18659c into godotengine:master Dec 19, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks! It doesn't look like we're going to address the restart issue soon, so this is a good PR to have in the meantime.

@jsjtxietian jsjtxietian deleted the require-editor-restart-when-csg-gizmo-color-changed branch December 20, 2023 02:09
@jsjtxietian
Copy link
Contributor Author

jsjtxietian commented Dec 20, 2023 •
edited
Loading

It could be updated on the fly yes

Yes it would require recreate the material after the color is changed. If there is a convient way of get notifed after the color is changed in project setting, it'd doable and should be pretty straight forward.

But many gizmo color are used in EditorNode3DGizmoPlugin , it's not a Node so no NOTIFICATION_EDITOR_SETTINGS_CHANGED for them.

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@fire fire Awaiting requested review from fire

Assignees
No one assigned
Labels
bug topic:editor topic:3d
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Missing prompt to restart editor when 3D Gizmo color editor settings changed
5 participants
@jsjtxietian @Calinou @YuriSizov @akien-mga @fire