Remove I/O error popup when failing to load/unload extension #82907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This spelling error ("veryfied") is unrelated to the PR but seems to be caught in |
I fixed it with 373c4b2, so you can just rebase. Sadly the current GitHub action we use to run codespell doesn't let us pin a version of codespell to use, so upstream dictionary updates mean that new typos can be found at any time when modifying a given file. |
mihe
force-pushed
the
gdext-failed-modal
branch
from
65dda88
to
1a80508
Compare
dsnopek
approved these changes
Oct 6, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #82861 this removes the modal error popup that happens when you fail to load/unload an extension.
Given that any important error is being (or at least should be) logged to the editor log anyway, and in greater detail there, this popup is almost entirely redundant. It's also quite annoying due to the fact that extension loading gets retried what seems like every couple of seconds, as well as when the editor gains focus, which makes the modal nature of this popup quite frustrating.