Add method to check if filesystem is case sensitive. #82957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Oct 7, 2023
akien-mga
reviewed
Oct 7, 2023
bruvzg
force-pushed
the
fs_case_check
branch
2 times, most recently
from
b38cdcb
to
59b883f
Compare
VedatGunel
reviewed
Oct 7, 2023
|
Tested on macOS and Windows 11, seems to work on both. For the reference: case-sensitive mode can be enabled for the directory using the following command: |
akien-mga
approved these changes
Oct 9, 2023
|
Why the method isn't static? You need to open a path and then provide another path... |
That would make sense to me. WDYT @bruvzg? |
The same is true for most of I guess it depends if it's will be used as relative or absolute path more often (but it's probably won't be used a lot, so there's no difference). |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19592