-
-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C#] Enable nullability for variant structs #82980
[C#] Enable nullability for variant structs #82980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for helping with the nullable annotations. Looks good, only a small nit-pick.
f39da0d
to
6fc74bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
7e24c17
to
69ff298
Compare
69ff298
to
05aa0f1
Compare
@Repiteo Just a note about contribution style, but we prefer when commit messages start with a verb describing the action in this change. In case of area prefixes the verb would come after them. See this document. This is relevant to your other PRs as well. |
@YuriSizov Ah! Thanks for clarifying, don't know how that detail escaped me Based off the documentation, it seems it'd still be acceptable to prefix with |
My bad got mixed up with the used styles 🙂 |
05aa0f1
to
d067c59
Compare
Yes, both options are acceptable. |
d067c59
to
db7a643
Compare
Thanks! |
Minor update on the road to GodotSharp being nullable by default. This focuses exclusively on the Variant structs, which are probably the one area that could be shifted over in full without issue. The only non-conversion change was in
Projection.cs
, where a new null check was added to handle a function returningVector3?
instead ofVector3
, matching GDScript implementation.