Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LOGO_LICENSE.md with license cleanly integrated into text and copyright symbol added #82989

Closed
wants to merge 1 commit into from

Conversation

SmashedFrenzy16
Copy link

@SmashedFrenzy16 SmashedFrenzy16 commented Oct 8, 2023

This change integrates the license into the text and adds the copyright symbol.

@Riteo
Copy link
Contributor

Riteo commented Oct 9, 2023

I mean, the (c) notation is also used in LICENSE.txt. Personally I'd make LOGO_LICENSE.md a txt file in the first place, to make it more consistent with LICENSE.txt.

@SmashedFrenzy16
Copy link
Author

@Riteo what about renaming LICENSE.txt to LICENSE.md like a lot of other repositories?

@Riteo
Copy link
Contributor

Riteo commented Oct 9, 2023

@SmashedFrenzy16 no idea tbh. This whole change is like extremely specific and small. 🤷

@akien-mga
Copy link
Member

Thanks for the contribution. I agree with some of the changes, but not all. Indeed changing it to a plain text file would make sense.

I went ahead and made my own update of the docs: #83095.

In general, we advise against new contributors making minor changes to repository documentation like this. This requires a lot of effort from maintainers to help shape the contribution so that it fits our PR workflow and style guides, for very minor changes.

@akien-mga akien-mga closed this Oct 10, 2023
@AThousandShips AThousandShips removed this from the 4.x milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants