Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace sanity with safety for checks #83002

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Replace sanity with safety for checks #83002

merged 1 commit into from
Oct 9, 2023

Conversation

AThousandShips
Copy link
Member

More inclusive language and something that has bothered me personally.

@AThousandShips AThousandShips added this to the 4.x milestone Oct 8, 2023
@AThousandShips AThousandShips requested review from a team as code owners October 8, 2023 14:24
@RandomShaper
Copy link
Member

Wouldn't this warrant a proposal? Well, unless it has already been discussed somewhere.

@AThousandShips
Copy link
Member Author

AThousandShips commented Oct 9, 2023 •
edited
Loading

It has been discussed in chat, and it is a common industry practice (it's in codespell for example)

akien-mga
akien-mga approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the change, there's no loss of meaning and it's less problematic.

@akien-mga akien-mga modified the milestones: 4.x, 4.2 Oct 9, 2023
@RandomShaper
Copy link
Member

Well, it it's been decided, it's been decided. I'll just abide by it. I don't think my opinion will matter much at this point.

Now, if this is the route we want to take, I'd like to have some sort of style guide with banned terms, etc.

@akien-mga akien-mga merged commit 336260b into godotengine:master Oct 9, 2023
15 checks passed
@AThousandShips AThousandShips deleted the safety_check branch October 9, 2023 13:43
@akien-mga
Copy link
Member

Thanks!

@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fire fire fire approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@AThousandShips @RandomShaper @akien-mga @fire