Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDExtension: Use correct return pointer for validated calls that return Variant #83054

Merged
merged 1 commit into from
Oct 10, 2023
Merged

GDExtension: Use correct return pointer for validated calls that return Variant #83054

merged 1 commit into from
Oct 10, 2023

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Oct 9, 2023 •
edited
Loading

Fixes #83016
Fixes #83097

Since I don't presently have a way to reproduce the bug, this will need some testing.

@dsnopek dsnopek added this to the 4.2 milestone Oct 9, 2023
@dsnopek dsnopek requested a review from a team as a code owner October 9, 2023 16:02
@dsnopek dsnopek mentioned this pull request Oct 9, 2023
Closed
@dsnopek dsnopek marked this pull request as draft October 9, 2023 16:05
@dsnopek dsnopek force-pushed the gdextension-validated-call-always-ret-pointer branch from 188650d to 74eccb1 Compare October 9, 2023 22:08
@dsnopek dsnopek changed the title Return a valid opaque pointer even for Variants of type NIL On validated calls to GDExtension, always pass a pointer for the return value Oct 9, 2023
@dsnopek dsnopek force-pushed the gdextension-validated-call-always-ret-pointer branch from 74eccb1 to 88b6fee Compare October 10, 2023 13:32
@dsnopek dsnopek changed the title On validated calls to GDExtension, always pass a pointer for the return value GDExtension: Use correct return pointer for validated calls that return Variant Oct 10, 2023
@dsnopek dsnopek mentioned this pull request Oct 10, 2023
Closed
@dsnopek dsnopek requested a review from vnen October 10, 2023 13:35
@dsnopek dsnopek marked this pull request as ready for review October 10, 2023 13:35
@dsnopek dsnopek requested a review from a team as a code owner October 10, 2023 13:35
@dsnopek dsnopek mentioned this pull request Oct 10, 2023
Merged
Bromeon
Bromeon approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@Bromeon Bromeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this fixes downstream godot-rust CI (at least according to one test 😛).
Thanks a lot!

@akien-mga akien-mga merged commit feb6ea2 into godotengine:master Oct 10, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@dsnopek dsnopek deleted the gdextension-validated-call-always-ret-pointer branch July 22, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bromeon Bromeon Bromeon approved these changes

@vnen vnen Awaiting requested review from vnen

Assignees
No one assigned
Labels
bug topic:gdextension
Projects
4.x Release Blockers
Archived in project
Milestone
4.2
3 participants
@dsnopek @akien-mga @Bromeon