Warn users when TileMap is set as Y-sorted but no layer is #83144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groud
force-pushed
the
tilemap_y_sort_warning
branch
from
cdb5d94
to
bdfb86b
Compare
akien-mga
reviewed
Oct 11, 2023
groud
force-pushed
the
tilemap_y_sort_warning
branch
from
bdfb86b
to
a3bfd9b
Compare
kleonc
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
The warning is fine but this PR does not close #83142, see #83142 (comment) and #83151.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClosesRelated to #83142This adds a warning when the TileMap is set as Y-sorting, but none of its layers is.