Fix tilemap live editing while game is running

[pancelor]

fixes #77328

thanks to @torcado194 for figuring out how to fix this!

I've been using this for a week or two with no problems in my simple use cases (single-layer single-source tilemaps)

[groud]

Hi! Thanks for trying to the solve the issue but this is not the right way to solve the problem.

The commit_action(false) call aims to avoid calling the functions on the locally edited TileMap for performance reasons. The argument cannot be removed like that as it would impact editing performances.

The issue must be solved in UndoRedo. I think solving the issue should be done by still calling the callbacks when p_execute is false. This means:

• Updating UndoRedo::commit_action to always call _process_operation_list but with an added p_execute argument.
• Adding a p_execute argument to _process_operation_list
• Only execute code when p_execute is true (the callable.callp(nullptr, 0, ret, ce) part), but still notify the debugger via the callback (check how method_callback is used)

[pancelor]

Ahh that makes more sense; thank you for the detailed steps! lmk how it looks

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉

[caimantilla]

Did this break again?
I've been struggling figuring out how to make my own Node type work with live editing, which led me here.
So, I added a TileMap, and the tiles I paint only show up in-game once I restart...

[KoBeWi]

Can't reproduce the problem, the TileMap updates normally for me.