Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error messages to the native menu and file dialogs callback. #83181

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Oct 12, 2023

Adds callback call error checks and messages to the native menu and native dialogs callbacks.

Fixes #83156

@akien-mga akien-mga added this to the 4.2 milestone Oct 12, 2023
@akien-mga akien-mga requested a review from KoBeWi October 12, 2023 06:36
@bruvzg bruvzg marked this pull request as ready for review October 12, 2023 07:06
@bruvzg bruvzg requested review from a team as code owners October 12, 2023 07:06
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but I think the errors should not be translated. We don't do that for printed errors.

@akien-mga akien-mga merged commit 18f12d1 into godotengine:master Oct 16, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@wyattbiker
Copy link

wyattbiker commented Jun 7, 2024

Which version was this fixed for? I just tested it on v4.3.dev5.official [c9c17d6] and does not work. When I say it does not work, I mean it does not get the callback.

I am on running on Linux
Operating System: Kubuntu 23.10
KDE Plasma Version: 5.27.8
KDE Frameworks Version: 5.110.0
Qt Version: 5.15.10
Kernel Version: 6.5.0-35-generic (64-bit)
Graphics Platform: X11
Processors: 16 × 12th Gen Intel® Core™ i7-1260P
Memory: 15.3 GiB of RAM
Graphics Processor: Mesa Intel® Graphics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DisplayServer file_dialog_show callable callback not firing.
4 participants