X11: Fix unused variables warning when touch is disabled
#83242
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Oct 13, 2023
There was a problem hiding this comment.
This looks correct, but I would suggest instead to move the definition of index and pos in the two case blocks that handle touch input. They shouldn't need to be computed for the other types of events.
Note: Please make modifications by amending the commit, and force pushing the changes, so that it stays as a single commit (see PR workflow).
akien-mga
changed the title
touch is disabled
akien-mga
changed the title
touch is disabledtouch is disabled
|
Superseded by #83265. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, someone at Godot team forgot to fix the ones that variables goes unused when they disable
touch.