-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OpenGL directional shadow last split fading #83252
Conversation
d7e21ba
to
7f6a93b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please squash these commits ? Godot contributing workflow says: “Most of the time, we will prefer a single commit in a given PR (unless there's a good reason to keep the changes separate).”
7f6a93b
to
09a2a7c
Compare
Squashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, let's nuke it. This was an accidental copy-paste from the GLES2 code in Godot 3.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected.
Thanks! And congrats for your first merged Godot contribution 🎉 |
Fixes #82505
I have no ideas what pssm fade was ment to do, however based on the shader code my guess is that it was an attempt to apply the fading controlled by fade start that got scrapped halfway through the implementation and replaced with a proper implementation, given that I cannot see anything of the sort in the Vulkan Renderer to indicate some other specific feature.