Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabling depth prepass break opaque materials #83371

Merged

Conversation

Lunarisnia
Copy link
Contributor

Changed so that when modifying the project setting related to depth prepass it prompt the user to restart Godot before continuing or else all opaque materials will break.

Fixes #82860

@Lunarisnia Lunarisnia requested a review from a team as a code owner October 15, 2023 05:22
@Chaosus Chaosus added this to the 4.2 milestone Oct 15, 2023
@clayjohn clayjohn added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 15, 2023
@akien-mga akien-mga merged commit bb83995 into godotengine:master Oct 16, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@Lunarisnia Lunarisnia deleted the fix/disabling-depth-prepass branch October 16, 2023 09:49
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling depth prepass in the Project Settings breaks opaque material rendering
6 participants