Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show AnimationMixer warning for non-numeric types only when relevant #83417

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Show AnimationMixer warning for non-numeric types only when relevant #83417

merged 1 commit into from
Oct 16, 2023

Conversation

Rubonnek
Copy link
Member

Without this patch, the warning will show regardless of whether the non-numeric tracks in the animation were set to UpdateMode.UPDATE_DISCRETE by the user.

@Rubonnek Rubonnek added bug topic:animation cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 15, 2023
@Rubonnek Rubonnek added this to the 4.2 milestone Oct 15, 2023
@Rubonnek Rubonnek requested a review from a team as a code owner October 15, 2023 23:26
TokageItLab
TokageItLab approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@TokageItLab TokageItLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's my bad, sorry! But maybe it is better for performance if if check is put before switch statement.

@TokageItLab TokageItLab removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 16, 2023
@TokageItLab TokageItLab mentioned this pull request Oct 16, 2023
Closed
@Rubonnek Rubonnek force-pushed the show-animation-mixer-warning-when-relevant branch from 73ac776 to 4c84970 Compare October 16, 2023 00:53
@Rubonnek
Copy link
Member Author

Oh, it's my bad, sorry! But maybe it is better for performance if if check is put before switch statement.

No worries! And thank you for all the work you've done with the animation system!

I've implemented your suggestion.

SaracenOne
SaracenOne approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga merged commit aa0be93 into godotengine:master Oct 16, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@Rubonnek Rubonnek deleted the show-animation-mixer-warning-when-relevant branch October 16, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaracenOne SaracenOne SaracenOne approved these changes

@TokageItLab TokageItLab TokageItLab approved these changes

Assignees
No one assigned
Labels
bug topic:animation
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Rubonnek @akien-mga @SaracenOne @TokageItLab