Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onion skinning internals activating audio/method/animation tracks #83430

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

RandomShaper
Copy link
Member

This should fix #83426, but I'd need it to be tested. @VansonLeung, would you give it a try, please?

@VansonLeung
Copy link

VansonLeung commented Oct 16, 2023

EDIT: re-test success with the proper practice. Please ignore my mini-project scenario.


My re-test failed:

retry.mp4

Mini - project:
gd_anim_unittest_1 2.zip

OS:
Mac OS 13.4, arm64

@VansonLeung
Copy link

VansonLeung commented Oct 16, 2023

FYI - Here is my test on Godot 4.1 stable version:

By considering this - I think the real trigger cause of this issue may not originate from onion skinning, but instead from something else. Turning on Onion Skinning just makes this issue happen to be more noticeable. @RandomShaper

If that is the case - should I also take a look at the part of the codes where audio animation key is being triggered? Or - is it an expected behaviour for Godot 4.1?

If the issue turns out to be recognized as a bug originating from the other issue stated in the link below, this particular pull request of yours may be optional / omitted / may need further fixes.

Edit: added a new issue: #83436

oldretry.mp4

@VansonLeung
Copy link

VansonLeung commented Oct 16, 2023

image

Per this it seemed that it was me doing the audio track animation key wrongly.

Ref: #83436

So I could say I tested your commit successfully with the stated issue #83426 fixed now. (Albeit the bug being practically not reproducible anymore when following the correct practice, even without this commit fix.)

@RandomShaper RandomShaper requested a review from a team October 23, 2023 18:45
@akien-mga akien-mga merged commit 3e23755 into godotengine:master Nov 12, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@RandomShaper RandomShaper deleted the fix_onion_audio branch November 13, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling Onion Skinning breaks Audio in Animation track
3 participants