Document AudioStreamGeneratorPlayback.get_skips()
#83435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
changed the title
AudioStreamGeneratorPlayback.get_skips()
YuriSizov
reviewed
Nov 2, 2023
YuriSizov
approved these changes
Nov 2, 2023
There was a problem hiding this comment.
Slight adjustment to the language is needed, but otherwise this seems correct.
When you apply the suggestion, please make sure to squash commits. The final commit should have a short but descriptive message (the title of this PR is a good option). See this documentation, if you need help with squashing.
|
Just double-checked that the new docs reflect the behavior as implemented. Looks good for audio after Yuri's suggestions. |
Co-Authored-By: Yuri Sizov <11782833+YuriSizov@users.noreply.github.com>
|
Done! |
|
Thanks, and congrats on your first merged Godot PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally posted by @Calinou in #48682 (comment)