[macOS] Remove deprecated altool notarization support, disable rcodesign for C# version. #83482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Oct 17, 2023
raulsntos
reviewed
Oct 17, 2023
There was a problem hiding this comment.
What does it mean to disable rcodesign for C#? Is that going to cause issues for exported projects? Should there be a warning in this case too?
Also, we should support exporting non-C# projects from the C# version of the editor. What does this change mean for this case?
…r rcodesign used with C# version.
akien-mga
approved these changes
Nov 2, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
altoolnotarization.rcodesignsupport for C# version and adds an error message if GDExtension libraries are found during export, sincercodesignis not capable of signing bundles with embedded libraries.