-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed multiple particle issues: division by zero, color ramp override, scale dependent on amount ratio #83488
Conversation
6fb59f8
to
f629e95
Compare
f629e95
to
cbf75f9
Compare
Discussed during the meeting today, we have concerns that the current random function generates numbers in a repeatable pattern. This is something we would ideally like to investigate before merging. EDIT: I am going to brute force test the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in this week's rendering meeting. Everything looks good. The concern I had over moving the AMOUNT_RATIO
check turned out to be unfounded. Moving AMOUNT_RATIO
is the correct fix
Thanks! |
Fix radial inwards velocity clamping incorrectly (regression from #83488)
Closes #83258
Fixes scale and amount ratio being tied together
Fixes initial ramp overriding color
The last two issues were reported to me in DM