Bump the java version to version 17 #83515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
added
platform:android
topic:buildsystem
cherrypick:3.x
|
Looks like we need to update the CI to Java 17 as well for the checks to pass. |
akien-mga
approved these changes
Oct 17, 2023
|
The CI build seems to fail. |
Yeah, it needs to be updated to Java 17 as well |
|
You could try this: diff --git a/.github/workflows/android_builds.yml b/.github/workflows/android_builds.yml
index ea97ef023d..495f643e56 100644
--- a/.github/workflows/android_builds.yml
+++ b/.github/workflows/android_builds.yml
@@ -20,11 +20,11 @@ jobs:
steps:
- uses: actions/checkout@v4
- - name: Set up Java 11
+ - name: Set up Java 17
uses: actions/setup-java@v3
with:
distribution: temurin
- java-version: 11
+ java-version: 17
- name: Setup Godot build cache
uses: ./.github/actions/godot-cache |
m4gr3d
force-pushed
the
bump_java_version_main
branch
from
05f6a9d
to
56ce2d9
Compare
|
Thanks! |
|
Included in #87588. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to godotengine/godot-docs#7968