Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setting bezier track handle mode from inspector #83533

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Fix setting bezier track handle mode from inspector #83533

merged 1 commit into from
Dec 16, 2023

Conversation

SaracenOne
Copy link
Member

Closes #74224

@SaracenOne SaracenOne added this to the 4.2 milestone Oct 18, 2023
AThousandShips
AThousandShips reviewed Oct 18, 2023
View reviewed changes
editor/animation_track_editor.cpp Outdated Show resolved Hide resolved
editor/animation_track_editor.cpp Outdated Show resolved Hide resolved
@SaracenOne
Copy link
Member Author

Okay, updated now!

@YuriSizov YuriSizov modified the milestones: 4.2, 4.3 Nov 13, 2023
@YuriSizov YuriSizov added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Nov 13, 2023
@YuriSizov YuriSizov requested review from a team November 13, 2023 16:33
@KoBeWi
Copy link
Member

KoBeWi commented Nov 13, 2023 •
edited
Loading

When you change the mode and it changes handles, doing undo will not undo handles.

W4o491mkcc.mp4

@SaracenOne
Copy link
Member Author

Should be fixed now!

@YuriSizov YuriSizov changed the title Fix setting bezier track handle mode from inspector. Fix setting bezier track handle mode from inspector Dec 16, 2023
@YuriSizov YuriSizov merged commit 9cbe3cb into godotengine:master Dec 16, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@YuriSizov YuriSizov removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jan 25, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@KoBeWi KoBeWi KoBeWi approved these changes

Assignees
No one assigned
Labels
bug topic:animation topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Setting handle mode on bezier curve from the inspector does nothing
4 participants
@SaracenOne @KoBeWi @YuriSizov @AThousandShips