Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Change return type of _Set method from void to bool in C# code example #83602

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Doc: Change return type of _Set method from void to bool in C# code example #83602

merged 1 commit into from
Oct 20, 2023

Conversation

copytime
Copy link
Contributor

This is clearly that the method return a boolean value instead of void.

@copytime copytime requested a review from a team as a code owner October 19, 2023 05:09
aaronfranke
aaronfranke reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the GDScript function is missing a return false, so it returns either true or void. I think we should fix the GDScript code too.

@copytime
Copy link
Contributor Author

Note that the GDScript function is missing a return false, so it returns either true or void. I think we should fix the GDScript code too.

That's right, a return value of "false" should be added to maintain consistency with the document description.

@akien-mga akien-mga added this to the 4.2 milestone Oct 19, 2023
@akien-mga
Copy link
Member

Looks good! Could you squash the commits? See PR workflow for instructions.

@copytime
Change return type of "_Set" method in csharp code example
458cb99 
Add "return false" to GDScript code example of _Set method
raulsntos
raulsntos approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@raulsntos raulsntos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing to the .NET documentation!

If this is cherry-picked, we should probably cherry-pick #80475 too.

@raulsntos raulsntos added topic:dotnet cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 19, 2023
@akien-mga akien-mga changed the title Doc: Change return type of "_Set" method from "void" to "bool" in csharp code example Doc: Change return type of _Set method from void to bool in C# code example Oct 19, 2023
@akien-mga akien-mga merged commit 34e3fa5 into godotengine:master Oct 20, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@YuriSizov YuriSizov removed cherrypick:4.0 cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulsntos raulsntos raulsntos approved these changes

@aaronfranke aaronfranke aaronfranke approved these changes

Assignees
No one assigned
Labels
bug documentation
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@copytime @akien-mga @YuriSizov @aaronfranke @raulsntos