Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCons: Use CXXFLAGS to disable exceptions, it's only for C++ #83618

Merged

Conversation

akien-mga
Copy link
Member

Following discussion in godotengine/godot-cpp#1216.

Note for 4.1 and 3.x cherry-picks: there's similar code to change in the denoise module.

@akien-mga akien-mga added enhancement topic:buildsystem cherrypick:3.x Considered for cherry-picking into a future 3.x release cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 19, 2023
@akien-mga akien-mga added this to the 4.2 milestone Oct 19, 2023
@akien-mga akien-mga requested a review from a team as a code owner October 19, 2023 14:29
Copy link
Collaborator

@Faless Faless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@akien-mga akien-mga merged commit 7065e2e into godotengine:master Oct 20, 2023
15 checks passed
@akien-mga akien-mga deleted the scons-no-exceptions-CXXFLAGS branch October 20, 2023 13:17
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3 (including the mentioned update to denoise). There is also /EHsc added to CCFLAGS in UWP's detect.py, but I'm not sure how important this is.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 24, 2023
@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants