Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shadow map debug visualization camera frustum index buffer size #83639

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

stoofin
Copy link
Contributor

@stoofin stoofin commented Oct 19, 2023

#81288 changed to 16-bit indices but missed a spot updating buffer sizes, so using Display Advanced... -> Directional Shadow Map doesn't show the camera frustum and fills Output with the following error in 4.2.beta2:

  Default index buffer initializer array size (144) does not match format required size (72).
  drivers/vulkan/rendering_device_vulkan.cpp:4584 - Condition "!index_buffer_owner.owns(p_index_buffer)" is true. Returning: RID()
  Default index buffer initializer array size (96) does not match format required size (48).
  drivers/vulkan/rendering_device_vulkan.cpp:4584 - Condition "!index_buffer_owner.owns(p_index_buffer)" is true. Returning: RID()
  drivers/vulkan/rendering_device_vulkan.cpp:7408 - Parameter "index_array" is null.
  Draw command requested indices, but no index buffer was set.
  drivers/vulkan/rendering_device_vulkan.cpp:7408 - Parameter "index_array" is null.
  Draw command requested indices, but no index buffer was set.

@stoofin stoofin requested a review from a team as a code owner October 19, 2023 21:04
@Calinou Calinou added this to the 4.2 milestone Oct 19, 2023
@akien-mga akien-mga merged commit 2a995c0 into godotengine:master Oct 20, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants