Optimize Path3DGizmo mesh generation #83741
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes the way Path3d editor preview meshes are generated by avoiding unnecessary reallocations and COW, as suggested by AThousandShips in #83698 (comment).
Also fixes a bug where the function would reach outside of the
frames
array when generating_collision_segments
.The function itself is bottlenecked mainly by the
sample_baked
function and as such the resulting times vary between 3.5s and 5.0s.As for the changes with the modified part of the function:
Build: editor x64
--production=yes
&debug_symbols=yes
Path3D with baked length of 26744.5: