Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clamp the height of description text for property selectors #83745

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Clamp the height of description text for property selectors #83745

merged 1 commit into from
Oct 25, 2023

Conversation

quirkylemon
Copy link
Contributor

Fixes #83495

New

Screenshot from 2023-10-21 13-33-58

Old

Screenshot from 2023-10-21 13-37-08

@quirkylemon quirkylemon changed the title Clamps the height of description text for property selectors Clamp the height of description text for property selectors Oct 21, 2023
@Chaosus Chaosus added this to the 4.2 milestone Oct 22, 2023
SaracenOne
SaracenOne approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, tested and this seems good. Much better UX. 👍

@akien-mga akien-mga merged commit 074297d into godotengine:master Oct 25, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@quirkylemon quirkylemon deleted the clamped-description-text branch October 25, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou left review comments

@SaracenOne SaracenOne SaracenOne approved these changes

Assignees
No one assigned
Labels
bug topic:editor usability
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Editor property selector does not clamp description
5 participants
@quirkylemon @akien-mga @Calinou @SaracenOne @Chaosus