Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TileSet painting options appear out of screen #83750

Closed
wants to merge 0 commits into from

Conversation

OppositeNor
Copy link
Contributor

@OppositeNor OppositeNor commented Oct 21, 2023

This is a fix for issue TileSet painting options appear out of screen issue #83610

Bugsquad edit:

@@ -836,6 +836,9 @@ void TileSetAtlasSourceEditor::_update_tile_data_editors() {
item->set_custom_color(0, disabled_color);
}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Too many lines

@AThousandShips AThousandShips requested a review from a team October 22, 2023 08:54
@akien-mga akien-mga changed the title Fix tileSet painting options appear out of screen Fix TileSet painting options appear out of screen Oct 22, 2023
@KoBeWi
Copy link
Member

KoBeWi commented Oct 22, 2023

A better solution would be changing this button to a proper OptionButton, but it's not that easy, so this solution works too for now.
Although seems like you did a wrong push and deleted the PR .-.

@OppositeNor
Copy link
Contributor Author

Um... Yeah I think I accidently deleted it.

@OppositeNor
Copy link
Contributor Author

I'll open a new one and try again.

@YeldhamDev YeldhamDev removed this from the 4.2 milestone Oct 22, 2023
@AThousandShips
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TileSet painting options appear out of screen
5 participants