Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix heap-use-after-free when resource loaded with load_threaded_request is never fetched #83782

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix heap-use-after-free when resource loaded with load_threaded_request is never fetched #83782

merged 1 commit into from
Oct 24, 2023

Conversation

timothyqiu
Copy link
Member

Fixes #83778

LoadToken's destructor erases itself from user_load_tokens, invalidating the iterator.

@timothyqiu timothyqiu added this to the 4.2 milestone Oct 22, 2023
@timothyqiu timothyqiu requested a review from a team as a code owner October 22, 2023 15:07
@timothyqiu @RandomShaper
Fix heap-use-after-free when resource loaded with load_threaded_reque…
dc7e309 
…st is never fetched

Co-authored-by: Pedro J. Estébanez <pedrojrulez@gmail.com>
@akien-mga akien-mga merged commit a1fd0b9 into godotengine:master Oct 24, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the self-awareness branch October 25, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@RandomShaper RandomShaper RandomShaper approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Heap use after free triggered by ResourceLoader.load_threaded_request
4 participants
@timothyqiu @akien-mga @RandomShaper @AThousandShips