Fix BaseButton `shortcut_feedback`'s timer will raise error when the button is removed from the scene tree #83925

jsjtxietian · 2023-10-25T06:48:56Z

Fixes #83867

when a button is removed from the scene tree

akien-mga · 2023-10-26T07:07:36Z

Thanks!

Fix BaseButton.shortcut_feedback's timer raises errors

47d601b

when a button is removed from the scene tree

jsjtxietian requested a review from a team as a code owner October 25, 2023 06:48

YeldhamDev added bug topic:gui labels Oct 25, 2023

YeldhamDev added this to the 4.2 milestone Oct 25, 2023

KoBeWi approved these changes Oct 25, 2023

View reviewed changes

akien-mga changed the title ~~Fix BaseButton.shortcut_feedback's timer will raise error when the button is removed from the scene tree~~ Fix BaseButton shortcut_feedback's timer will raise error when the button is removed from the scene tree Oct 25, 2023

akien-mga merged commit e566167 into godotengine:master Oct 26, 2023
15 checks passed

jsjtxietian deleted the fix-timer-error-when-base-button-leave-tree-and-feedback branch October 26, 2023 09:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix BaseButton `shortcut_feedback`'s timer will raise error when the button is removed from the scene tree #83925

Fix BaseButton `shortcut_feedback`'s timer will raise error when the button is removed from the scene tree #83925

jsjtxietian commented Oct 25, 2023

akien-mga commented Oct 26, 2023

Fix BaseButton shortcut_feedback's timer will raise error when the button is removed from the scene tree #83925

Fix BaseButton shortcut_feedback's timer will raise error when the button is removed from the scene tree #83925

Conversation

jsjtxietian commented Oct 25, 2023

akien-mga commented Oct 26, 2023

Fix BaseButton `shortcut_feedback`'s timer will raise error when the button is removed from the scene tree #83925

Fix BaseButton `shortcut_feedback`'s timer will raise error when the button is removed from the scene tree #83925