-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for EGL 1.4 #83930
Add support for EGL 1.4 #83930
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.5 was assumed as default when EGL was only used with ANGLE on macOS/Windows, for X11 in should be fine to 1.4 (not sure about Wayland).
089922a
to
30f0a67
Compare
30f0a67
to
27692bd
Compare
Trying to fix the formatting. @bruvzg This change should theoretically not affect newer systems with EGL 1.5 in place |
I'd recommend using |
Please amend your commits instead of making new ones, with |
838bad1
to
dbabf5c
Compare
too late to ammend but I haves squashed them now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit surprised that EGL 1.5 is still not widely supported (from what I can tell, it's a 9+ years old spec), that said, improving compatibility is very good! :)
Still, the way the version is checked is a bit redundant in some places and outright wrong in the others, so some changes are due.
That is sadly very often the case with embedded arm devices. lots of manufacturers have their own OS or push Android and Debian is just an afterthought. |
dbabf5c
to
6bbb2a2
Compare
6bbb2a2
to
00289d1
Compare
00289d1
to
249aed4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, great job! Thanks for your patience!
For posterity: since we're just checking two versions a normal Sound trivial but I can imagine forgetting about it in the distant future. |
Thanks! |
Debian 10 and (I think) 11 only have libEGL Version 1.4. Those OS are still widely used in integrated hardware like Rock PI and similar ARM devices.
This patch checks for the EGL version and calls older methods if necessary.