Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix animation track paths updated by scene dock #83934

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Fix animation track paths updated by scene dock #83934

merged 1 commit into from
Oct 28, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Oct 25, 2023

Fixes #83908
There is still some error when moving AnimationPlayer, but looks harmless and unrelated.

@KoBeWi KoBeWi added this to the 4.2 milestone Oct 25, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner October 25, 2023 10:22
@KoBeWi KoBeWi force-pushed the give_back_animations_to_animation_editor branch from e50c280 to 294ce2d Compare October 25, 2023 10:35
@SaracenOne SaracenOne self-assigned this Oct 28, 2023
SaracenOne
SaracenOne approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, tested this and it seems to fix the bug. Would recommend merging this ASAP due to the risk of data loss. LGTM 👍

@akien-mga akien-mga merged commit dc3a643 into godotengine:master Oct 28, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the give_back_animations_to_animation_editor branch October 28, 2023 17:35
@YuriSizov YuriSizov mentioned this pull request Nov 29, 2023
Merged
@TokisanGames TokisanGames mentioned this pull request Jul 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@SaracenOne SaracenOne SaracenOne approved these changes

Assignees

@SaracenOne SaracenOne

Labels
bug regression topic:animation topic:editor
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Reparenting an AnimationPlayer node to a higher node results in track information getting lost
4 participants
@KoBeWi @akien-mga @SaracenOne @AThousandShips