Expose energy_multiplier to remaining SkyMaterials
#83938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rial These are needed to tweak sky exposure separately from background
Calinou
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Tested locally, it works as expected. This makes sense to have as 3.x had similar capabilities.
This is useful to multiply sky energy when it's used only as ambient light (the Ambient Light Energy property only affects the color that is mixed with the sky color if Ambient Light Sky Contribution is less than 1.0):
simplescreenrecorder-2023-12-11_22.16.44.mp4
That said, it could be argued the behavior I mentioned is a bug as 3.x didn't behave like this: #56139
akien-mga
changed the title
energy_multiplier to remaining SkyMaterialsenergy_multiplier to remaining SkyMaterials
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported on twitter: https://x.com/PLyczkowski/status/1717134276133589340?s=20
These are needed to tweak sky exposure separately from background. We had the ability to modify exposure in 3.x. In 4.x I partially brought it back, but only for PhysicalSkyMaterial. For PanoramaSkyMaterial the function definitions were added, but not implemented. For ProceduralSkyMaterial you have to adjust ground energy and sky energy separately, which really sucks.