Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure input event is valid in PopupMenu::activate_item_by_event #83952

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Ensure input event is valid in PopupMenu::activate_item_by_event #83952

merged 1 commit into from
Oct 26, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Oct 25, 2023 •
edited
Loading

@AThousandShips AThousandShips added bug crash topic:gui cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 25, 2023
@AThousandShips AThousandShips added this to the 4.2 milestone Oct 25, 2023
@AThousandShips AThousandShips requested a review from a team as a code owner October 25, 2023 15:46
@akien-mga akien-mga merged commit cb167fd into godotengine:master Oct 26, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the popup_crash branch October 26, 2023 07:19
@AThousandShips
Copy link
Member Author

Thank you!

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug crash topic:gui
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Executing PopupMenu.activate_item_by_event function crashes Godot
3 participants
@AThousandShips @akien-mga @YuriSizov