Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the launchMode for the GodotApp activity #83954

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Oct 25, 2023

This allows other activities to be part of the same task

For details, see https://developer.android.com/guide/topics/manifest/activity-element#lmode

Fixes #83924

3.x version

@m4gr3d m4gr3d added bug platform:android topic:porting cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 25, 2023
@m4gr3d m4gr3d added this to the 4.2 milestone Oct 25, 2023
@m4gr3d
Copy link
Contributor Author

m4gr3d commented Oct 25, 2023

Waiting for confirmation this fixes the issue in #83924 (comment)

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as it seems confirmed to fix the issue.
There's still a question about whether singleInstancePerTask or singleTask would be best.

@m4gr3d m4gr3d marked this pull request as ready for review October 30, 2023 17:25
@m4gr3d m4gr3d requested a review from a team as a code owner October 30, 2023 17:25
@akien-mga akien-mga merged commit befc5a9 into godotengine:master Oct 30, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.3.

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Nov 1, 2023
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Nov 2, 2023
@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android activity launchMode should set to "singleTask"
3 participants