Only update EditorSceneTabs
tabs when necessary
#83957
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes resizing rebuilds all tabs
Fixes updating scene unsaved state (basically every action) rebuilds all tabs
Fixes #81513
Fixes this TODO in editor_scene_tabs
update_scene_tabs
now resizes its tabs only if it needs to, instead of always clearing and adding one by one.added
_update_tab_titles
- updates the titles and icons of tabs. If the tab already has those values, it will not redraw.added
_scene_tabs_resized
- repositions the add button. Used when resizing.This could be optimized further by updating only the affected tab.
Needs testing on Mac to make sure the global menu works as expected. Particularly that it updates its name based on saved/unsaved state and that reordering tabs doesn't break it.