-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method check for _notify_skeleton_bones_renamed
.
#83986
Add method check for _notify_skeleton_bones_renamed
.
#83986
Conversation
_notify_skeleton_bones_renamed
.
Hmm, I didn't actually. It's somewhat hard to say which is a more appropriate fix. Hypothetically with this approach, you could allow other nodes which could consume this event, but honestly, I think checking for BoneAttachment3D would be fine since this is just one relatively bespoke notification event. If we changed this to a cast, even though it's exclusively an editor only thing, we could also remove an extra method bind I guess. |
I think a cast and removing the unnecessary binding would be better. BTW the current cast to Node seems redundant since the elements of the TypedArray are Nodes already. |
38edfec
to
079b2ab
Compare
Okay, I've modified it now to remove the bind, and use casting instead. I didn't put the change @dpalais made in case you want to merge that seperately, though I can put it in mine too if you'd prefer this all be one PR. It's not strictly nessecary, but it results in less looping and feels like good practice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpicks, but looks good to me otherwise.
079b2ab
to
127fc6d
Compare
Oh, I could have sworn I put the include in the right order. I think my IDE did something strange. Anyway, it's resolved now. |
127fc6d
to
d0e5bff
Compare
Oh, another minor thing I missed: got rid of the redunant vargs since we don't need them anymore. |
Thanks! |
Adds check for existence of _notify_skeleton_bones_renamed method when walking nodes in PostImportPluginSkeletonRenamer. Silences errors and closes #83148