Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reading shadow filter quality from project settings in compatibility #83998

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Fix reading shadow filter quality from project settings in compatibility #83998

merged 1 commit into from
Oct 26, 2023

Conversation

chybby
Copy link
Contributor

@chybby chybby commented Oct 26, 2023

Fixes #83380.
Supersedes #83943.

@chybby chybby requested a review from a team as a code owner October 26, 2023 12:30
@AThousandShips AThousandShips mentioned this pull request Oct 26, 2023
Closed
@AThousandShips AThousandShips added this to the 4.2 milestone Oct 26, 2023
@AThousandShips
Copy link
Member

Copied from previous PR, by Akien:

For Clay when reviewing: might be worth double checking in RendererSceneRenderRD::init() whether there's any other setting supported in the GL Compat renderer that's not properly initialized.

clayjohn
clayjohn approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Great work!

@akien-mga akien-mga merged commit c5c90fd into godotengine:master Oct 26, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips left review comments

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:rendering topic:3d
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Compatibility Renderer Soft Shadows at locked at PCF5 at runtime
4 participants
@chybby @AThousandShips @akien-mga @clayjohn