Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GDScript: Fix UNSAFE_CAST warning #84043

Merged
merged 1 commit into from
Apr 9, 2024
Merged

GDScript: Fix UNSAFE_CAST warning #84043

merged 1 commit into from
Apr 9, 2024

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev added this to the 4.3 milestone Oct 27, 2023
@dalexeev dalexeev requested review from a team as code owners October 27, 2023 08:30
@dalexeev dalexeev force-pushed the gds-fix-unsafe-cast-warning branch from 6406327 to eb416dd Compare October 27, 2023 08:33
@dalexeev dalexeev force-pushed the gds-fix-unsafe-cast-warning branch from eb416dd to 6e996a5 Compare October 27, 2023 09:45
akien-mga
akien-mga approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward and with ample unit testing to validate it.

@akien-mga akien-mga merged commit f8ca571 into godotengine:master Apr 9, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the gds-fix-unsafe-cast-warning branch April 9, 2024 21:53
@mihe mihe mentioned this pull request Apr 26, 2024
Closed
@pineapplemachine pineapplemachine mentioned this pull request Jul 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

UNSAFE_CAST warning on dictionary field accessors
2 participants
@dalexeev @akien-mga