-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid return from some _get/_set
#84054
Conversation
Invalidly returned `true` on the non-matched path
1ff9ce2
to
b04cf84
Compare
ArrayMesh::_get
_get/_set
Given the very varying style and format of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems fine. Would appreciate the @godotengine/animation team to confirm that there is no required magic going on with those (if there is, we ought to add comments about that, not just leave it as is).
Indeed, will go over the animation cases later and open a PR for them but they require a bit more work, and will add comments there otherwise if there's some reason Edit: Was checking if the 3.x version also needed fixing but it appears it has a very different code for these cases, and looks like the error snuck in with the refactoring of it |
Thanks! |
Thank you! |
Magic! |
Cherry-picked for 4.1.4. |
Invalidly returned
true
on the non-matched path, these do not break anything by blocking inherited properties, at least not right nowThere are some remaining cases for
Skeleton
andSkeletonModification*
, but they are a bit more complicated so not touching them right now, these were the trivial cases