Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NavigationObstacle3DEditor parenting error #84055

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

smix8
Copy link
Contributor

@smix8 smix8 commented Oct 27, 2023

Fixes NavigationObstacle3DEditor parenting error.

Fixes #84050.

The NavigationObstacle3DEditor is based on the polygon 3d plugin which has received fix #73726.
So this pr is applying the same fix for the obstacle.

@smix8 smix8 added this to the 4.2 milestone Oct 27, 2023
@smix8 smix8 requested a review from a team as a code owner October 27, 2023 13:34
Fixes NavigationObstacle3DEditor parenting error.
@fire
Copy link
Member

fire commented Oct 27, 2023

How do I test this? Is there a mrp or some steps?

@smix8
Copy link
Contributor Author

smix8 commented Oct 27, 2023

@fire
Add 2x NavigationObstacle3D nodes in the scene, without the fix you get parent error msgs when you switch selection between them.

@akien-mga akien-mga merged commit b662d23 into godotengine:master Oct 27, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@smix8 smix8 deleted the navobstacle_editor branch October 27, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Already has parent' error adding or selecting NavigationObstacle3D
4 participants